Skip to content

Fix vstest analyzer errors #16269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

Fix vstest analyzer errors #16269

merged 1 commit into from
Apr 28, 2023

Conversation

@mthalman
Copy link
Member

@mthalman mthalman commented Apr 27, 2023

Ignores the following analyzer errors when attempting to run a bootstrap stage 2 build:

/repos/dotnet/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/InvalidManagedNameException.cs(14,93): error SYSLIB0051: 'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete: 'This API supports obsolete formatter-based serialization. It should not be called or extended by application code.' (https://aka.ms/dotnet-warnings/SYSLIB0051) [/repos/dotnet/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.AdapterUtilities/Microsoft.TestPlatform.AdapterUtilities.csproj::TargetFramework=net8.0]

/repos/dotnet/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.Utilities/XmlUtilities.cs(96,65): error IDE0059: Unnecessary assignment of a value to 'childNodeNavigator' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0059) [/repos/dotnet/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.Utilities/Microsoft.TestPlatform.Utilities.csproj::TargetFramework=net8.0]

Related: microsoft/vstest#4424, microsoft/vstest#4425

@mthalman mthalman requested a review from a team as a code owner April 27, 2023 19:24
@mthalman mthalman merged commit 11a0906 into dotnet:release/8.0.1xx-preview4 Apr 28, 2023
@mthalman mthalman deleted the vstest-analyzer branch April 28, 2023 12:32
mthalman added a commit to mthalman/installer that referenced this pull request Apr 28, 2023
@mthalman
Fix vstest analyzer errors (dotnet#16269)
7a311d1 
(cherry picked from commit 11a0906)
@mthalman mthalman mentioned this pull request Apr 28, 2023
Merged
mthalman added a commit that referenced this pull request Apr 28, 2023
@mthalman
Fix vstest analyzer errors (#16269) (#16277)
c730f25
@mthalman mthalman mentioned this pull request May 1, 2023
Closed
@mthalman mthalman mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mthalman @NikolaMilosavljevic